Skip to content

Conversation

@glsukki
Copy link
Contributor

@glsukki glsukki commented Oct 16, 2025

The NotRequired construct from typing is supported only in Python 3.11.

To avoid breaking dependencies which use a lower version (Python <3.11) - replacing the NotRequired with Optional for the EventMetadataFilter.right field.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@1bdddf6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/bedrock_agentcore/memory/models/filters.py 54.54% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage        ?   89.54%           
=======================================
  Files           ?       24           
  Lines           ?     2391           
  Branches        ?      341           
=======================================
  Hits            ?     2141           
  Misses          ?      146           
  Partials        ?      104           
Flag Coverage Δ
unittests 89.54% <58.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jona62 jona62 merged commit 806ee26 into aws:main Oct 16, 2025
15 of 16 checks passed
@glsukki glsukki deleted the fix/linting-remove-required branch October 16, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants