-
Notifications
You must be signed in to change notification settings - Fork 434
fix: check if docker is running should work for windows #5660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🍕 Here are the new binary sizes!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mainline #5660 +/- ##
=============================================
- Coverage 93.25% 70.05% -23.20%
=============================================
Files 14 303 +289
Lines 1630 46626 +44996
Branches 299 299
=============================================
+ Hits 1520 32663 +31143
- Misses 105 12379 +12274
- Partials 5 1584 +1579 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
we have some other places where we are running similar sort of commands in the codebase to access a particular object in json format, for example over here and here Is the Output format is same in both windows, mac and linux when accessing individual object. we need @CaptainCarpensir help for this 😄 |
Good call! We def. need his help before merging this PR. The root problem is for windows |
|
Tested offline on my windows PC and it seems finally working! |
Fixes #5656
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.