Skip to content

Conversation

@iamhopaul123
Copy link
Contributor

Fixes #5656

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner February 6, 2024 19:14
@iamhopaul123 iamhopaul123 requested review from efekarakus and removed request for a team February 6, 2024 19:14
@github-actions
Copy link

github-actions bot commented Feb 6, 2024

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 57536 57312 +0.39
macOS (arm) 58580 58332 +0.43
linux (amd) 50444 50252 +0.38
linux (arm) 49728 49540 +0.38
windows (amd) 47516 47340 +0.37

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.05%. Comparing base (d3b36ac) to head (7ce9950).
Report is 114 commits behind head on mainline.

Files with missing lines Patch % Lines
internal/pkg/docker/dockerengine/dockerengine.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           mainline    #5660       +/-   ##
=============================================
- Coverage     93.25%   70.05%   -23.20%     
=============================================
  Files            14      303      +289     
  Lines          1630    46626    +44996     
  Branches        299      299               
=============================================
+ Hits           1520    32663    +31143     
- Misses          105    12379    +12274     
- Partials          5     1584     +1579     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KollaAdithya
Copy link
Contributor

we have some other places where we are running similar sort of commands in the codebase to access a particular object in json format, for example over here and here

Is the Output format is same in both windows, mac and linux when accessing individual object.
Do we need to verify this as well.

we need @CaptainCarpensir help for this 😄

@iamhopaul123
Copy link
Contributor Author

we have some other places where we are running similar sort of commands in the codebase to access a particular object in json format, for example over here and here

Is the Output format is same in both windows, mac and linux when accessing individual object. Do we need to verify this as well.

we need @CaptainCarpensir help for this 😄

Good call! We def. need his help before merging this PR. The root problem is for windows docker info gives an extra line before the json. If the other docker command doesn't have similar issue we are probably good for now.

@iamhopaul123
Copy link
Contributor Author

Tested offline on my windows PC and it seems finally working!

@mergify mergify bot merged commit 5ee9a70 into aws:mainline Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Problem with Docker

4 participants