detect invalid private key #130
Conversation
The `privateKey.pem` can become an empty file due to several reasons, but this case is falsely detected as an existing valid key. Instead of just assuming an existing file means a valid key, at least there should be a check if the file is not empty. There are several issues filed that cover this situation: kubernetes-sigs/aws-efs-csi-driver#683 kubernetes-sigs/aws-efs-csi-driver#569 Signed-off-by: Samuel Lang <gh@lang-sam.de>
|
@universam1 nice find Great if this fix solves this nasty issue 👍 |
|
Could someone merge this? |
|
@tmunipre please consider this fix, thank you |
|
Could this please be reviewed. |
|
/lgtm |
|
@universam1 Thank you for creating this PR! Sorry it wasn't merged earlier. |
|
Thank you @RyanStan for taking the PR further, appreciated! |
|
Yep, once we cut a release of efs-utils, we'll be able to propagate it to the csi driver. This is on our immediate radar now |
|
This was included in v1.4.9 of aws-efs-csi-driver. |
|
We are still facing this problem on v1.4.9, I believe we need the same check on the |
8 participants
Issue #, if available:
kubernetes-sigs/aws-efs-csi-driver#683
kubernetes-sigs/aws-efs-csi-driver#569
Description of changes:
The
privateKey.pemcan become an empty file due to several reasons, but this case is falsely detected as an existing valid key.Instead of just assuming an existing file means a valid key, at least there should be a check if the file is not empty.