fix(jsii-pacmak): compilation fails if a type is named "Object" #4990
+78
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When jsii is used to emit a type name `"Object"`, the definition of the `equals()` method that `jsii-pacmak` generates changes meaning: ```java // This is meant to reference the built-in Object class @OverRide public final boolean equals(final Object o) { } // But with a local "Object" class present, this now references // the local class. ``` We then get the errors: ``` error: method does not override or implement a method from a supertype error: incomparable types: Jsii$Proxy and Object ... ``` And a bunch more. Instead, emit the `equals()` method with a fully qualified reference to `java.lang.Object` so the aliasing can't happen.
mrgrain
approved these changes
Nov 26, 2025
vishaalmehrishi
approved these changes
Nov 26, 2025
Contributor
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Contributor
Merge Queue Status
✅ The pull request has been merged This pull request spent 6 seconds in the queue, with no time waiting for CI. Required conditions to merge
|
Contributor
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When jsii is used to emit a type name
"Object", the definition of theequals()method thatjsii-pacmakgenerates changes meaning:We then get the errors:
And a bunch more.
Instead, emit the
equals()method with a fully qualified reference tojava.lang.Objectso the aliasing can't happen.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.