feat(types): add isMcpRegistry field to MCP protocol types #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chungjac
approved these changes
Nov 11, 2025
Will-ShaoHua
approved these changes
Nov 11, 2025
ashishrp-aws
pushed a commit
that referenced
this pull request
Nov 11, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>chat-client-ui-types: 0.1.68</summary> ## [0.1.68](chat-client-ui-types/v0.1.67...chat-client-ui-types/v0.1.68) (2025-11-11) ### Dependencies * The following workspace dependencies were updated * dependencies * @aws/language-server-runtimes-types bumped from ^0.1.61 to ^0.1.62 </details> <details><summary>language-server-runtimes: 0.3.6</summary> ## [0.3.6](language-server-runtimes/v0.3.5...language-server-runtimes/v0.3.6) (2025-11-11) ### Dependencies * The following workspace dependencies were updated * dependencies * @aws/language-server-runtimes-types bumped from ^0.1.61 to ^0.1.62 </details> <details><summary>language-server-runtimes-types: 0.1.62</summary> ## [0.1.62](language-server-runtimes-types/v0.1.61...language-server-runtimes-types/v0.1.62) (2025-11-11) ### Features * **types:** add isMcpRegistry field to MCP protocol types ([#710](#710)) ([c6028b0](c6028b0)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MCP registry UI handling was using hacky type casts like
(params as any).isRegistryActiveto determine if a server is from the registry. This approach is not type-safe and makes the code harder to maintain and understand.Solution
Add
isMcpRegistryoptional boolean field to MCP protocol types:ListMcpServersParamsListMcpServersResultMcpServerClickParamsMcpServerClickResult(inherited fromMcpServerClickParams)This allows proper type-safe tracking of MCP registry state throughout the protocol communication between server and client.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.