fix(amazonq): fix processing empty unsupported workspace file #2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
==========================================
- Coverage 60.91% 60.91% -0.01%
==========================================
Files 239 239
Lines 52576 52597 +21
Branches 3176 3179 +3
==========================================
+ Hits 32027 32038 +11
- Misses 20487 20497 +10
Partials 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leigaol
reviewed
Jul 31, 2025
| onlyFiles: true, | ||
| }) | ||
|
|
||
| const hasJavaFile = files.some(file => file.endsWith('.java')) |
There was a problem hiding this comment.
in this function when you get files, please use fast glob streaming methods. See #2003
There was a problem hiding this comment.
Ack let me refactor this to streaming methods
There was a problem hiding this comment.
@leigaol added the same glob.stream with early exist on MAX_FILES
liumofei-amazon
force-pushed
the
classpathfix
branch
2 times, most recently
from
b876c76 to
e3b4cd2
Compare
liumofei-amazon
force-pushed
the
classpathfix
branch
from
e3b4cd2 to
bbfeb9f
Compare
leigaol
approved these changes
Aug 1, 2025
chungjac
pushed a commit
that referenced
this pull request
Aug 4, 2025
* fix(amazonq): improve cross theme support (#2036) * fix(amazonq): fix processing empty unsupported workspace file (#2017) * test: fix integration tests on windows (#2041) * fix(amazonq): fix for mcp server permissions to prefer workspace agent config files (#2038) * chore: add integ test badge (#2042) * feat(amazonq): implement displayFindings tool (#2029) * feat(amazonq): implement displayFindings tool * feat(amazonq): add unit tests for display findings tool * fix(amazonq): simplify displayFindings unit tests, collapse switch statement * fix(amazonq): emit metrics for displayFindings, fix error handling, improve unit tests --------- Co-authored-by: abhraina-aws <abhraina@amazon.com> Co-authored-by: liumofei-amazon <98127670+liumofei-amazon@users.noreply.github.com> Co-authored-by: Tai Lai <ctlai95@gmail.com> Co-authored-by: invictus <149003065+ashishrp-aws@users.noreply.github.com> Co-authored-by: BlakeLazarine <blake.l.lazarine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
From the priors change workspace context is not handling
.scala.ktproject correctly by uploading an empty project file.This PR to address this issue, only adding the
pom.xmlgradle.build.ktsgradle.buildbuild.xmlif there's java source file existing.Solution
Move the logic assign the language override inside
artifactManager, only process these projectFile if there's.javasource file exist so we do not upload it for kotlin/scala/smithy projects which will result an empty zip with project file onlyAlso introduce the fix using glob.stream and have upper limit of file count from this commit
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.