fix: improve history management #2312
Conversation
jguoamz
force-pushed
the
slidingWindow
branch
3 times, most recently
from
c34b0fb to
e31a621
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/historyV2 #2312 +/- ##
==================================================
Coverage 60.17% 60.17%
==================================================
Files 256 256
Lines 57054 56982 -72
Branches 3499 3496 -3
==================================================
- Hits 34332 34291 -41
+ Misses 22656 22625 -31
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jguoamz
force-pushed
the
slidingWindow
branch
from
e31a621 to
ccf2b70
Compare
| // Compaction | ||
| // Maximum number of characters per request used for compaction prompt | ||
| // 200K tokens * 3.5 = 700K characters, intentionally overestimating with 3.5:1 ratio | ||
| export const MAX_OVERALL_CHARACTERS = 700_000 |
There was a problem hiding this comment.
Not related to this change but just curious: In case we introduce more new models in the future, and the models might have different limits, we need to change this to a model -> maxChar map?
|
|
||
| // 1. Make sure the length of the history messages don't exceed MaxConversationHistoryMessages | ||
| let allMessages = this.getMessages(tabId, maxConversationHistoryMessages) | ||
| let allMessages = this.getMessages(tabId) |
There was a problem hiding this comment.
Just to confirm, this returns all the messages across different conversationIds under the tabId? Can you double check if there's a limitation on the number of messages included under history? I don't really remember why we had MaxConversationHistoryMessages.
There was a problem hiding this comment.
the limit is removed
4 participants
Problem
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.