Skip to content

Conversation

laileni-aws
Copy link
Contributor

Problem

  • XSS issue fix PR is causing cache misses because the history is different (with escaped HTML)

Solution

  • Escape userInput as part of initial sanitizeInput this should cover all the cases like
    • If user reloads IDE, Q use chat history to show previous tabs.
    • If user clicks on History icon then Q get data from chat history to show in the UI.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laileni-aws laileni-aws requested a review from a team as a code owner September 29, 2025 21:22
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.92%. Comparing base (d56bfa1) to head (a8a1720).

Files with missing lines Patch % Lines
...nguage-server/agenticChat/agenticChatController.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2360      +/-   ##
==========================================
- Coverage   59.92%   59.92%   -0.01%     
==========================================
  Files         258      258              
  Lines       58236    58235       -1     
  Branches     3552     3553       +1     
==========================================
- Hits        34899    34898       -1     
  Misses      23271    23271              
  Partials       66       66              
Flag Coverage Δ
unittests 59.92% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laileni-aws laileni-aws merged commit 45b86be into aws:main Sep 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants