Skip to content

Conversation

@mazyu36
Copy link
Contributor

@mazyu36 mazyu36 commented Nov 1, 2025

Summary

Fix type annotation mismatch in add_logging_middleware function.

The log_level parameter was incorrectly annotated as int but actually receives string values ('DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL') from argparse.

Changes

Changed log_level parameter type annotation from int to str in add_logging_middleware() function in mcp_proxy_for_aws/server.py

User experience

No user-facing changes.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

  • Yes
  • No

Please add details about how this change was tested.

  • Did integration tests succeed?
  • If the feature is a new use case, is it necessary to add a new integration test case?

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mazyu36 mazyu36 requested a review from a team as a code owner November 1, 2025 15:02
@mazyu36 mazyu36 requested review from jinet and vtols November 1, 2025 15:02
@acmlau acmlau merged commit 9b00656 into aws:main Nov 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants