Skip to content

Conversation

@arangatang
Copy link
Contributor

Fixes failures when connecting to an Agentcore service.

Summary

Bedrock AgentCore url structure does not align to our current --service detection regex. For now i'm adding an override if we realize we will need more overrides as time goes on we should re-evaluate the regex itself.

Changes

Adding a check for .bedrock-agentcore. in the url and using this as service if found.

User experience

After fix users connecting to AgentCore can omit the --service flag.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

  • Yes
  • No

Please add details about how this change was tested.

  • Did integration tests succeed?
  • If the feature is a new use case, is it necessary to add a new integration test case?

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@arangatang arangatang requested a review from a team as a code owner November 6, 2025 14:24
@arangatang
Copy link
Contributor Author

Should fix #78

@arangatang arangatang enabled auto-merge (squash) November 6, 2025 14:26
kyoncal
kyoncal previously approved these changes Nov 6, 2025
Copy link
Contributor

@harv-aws harv-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned on functionality. added a minor comment on test.

kyoncal
kyoncal previously approved these changes Nov 11, 2025
…ervice name detection

Fixes failures when connecting to an Agentcore service.
@arangatang arangatang merged commit 3f58d5d into aws:main Nov 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants