fix(sigv4_helper.py): reduce severity of log levels #86
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzxxing
approved these changes
Nov 13, 2025
wzxxing
requested changes
Nov 13, 2025
some items in sigv4_helper.py were logged as error level, which caused some problems with some MCP clients.
kyoncal
force-pushed
the
fix/metadata-log-level
branch
from
4e7c380 to
49f438c
Compare
arangatang
reviewed
Nov 13, 2025
| ) | ||
| body['params']['_meta'] = {**metadata, **existing_meta} | ||
| else: | ||
| logger.info('Replacing non-dict _meta value with injected metadata') |
Contributor
There was a problem hiding this comment.
Thanks for the change! Could you also add a section in the readme under troubleshooting that Cline has some issues with logging during the connection phase and count those as errors?
Contributor
There was a problem hiding this comment.
Thanks for noticing this. @kyoncal This is the weird part of the cline code for your reference.
wzxxing
approved these changes
Nov 13, 2025
arangatang
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Log levels were changed.
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
Please add details about how this change was tested.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.