Add pgactive worker error reporting facility #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmay
requested changes
Sep 10, 2024
BRupireddy2
force-pushed
the
add_pgactive_worker_error_reporting_facility_WIP
branch
2 times, most recently
from
ea50ef6 to
d78bdd9
Compare
sharmay
requested changes
Sep 10, 2024
BRupireddy2
force-pushed
the
add_pgactive_worker_error_reporting_facility_WIP
branch
from
d78bdd9 to
d01915b
Compare
bdrouvotAWS
reviewed
Sep 12, 2024
This commit enables pgactive per-db and apply workers to report their last error into shared memory. Users can see the last error info via pgactive_get_workers_info SQL function. One error for each per-db and apply worker is added for now. This can be extended to other errors by adding a specific pgactive error code and emitting error via the ereport_pgactive() in place of ereport()/elog(). This last error info improves observability of the pgactive setups in production.
BRupireddy2
force-pushed
the
add_pgactive_worker_error_reporting_facility_WIP
branch
from
d01915b to
7648977
Compare
bdrouvotAWS
approved these changes
Sep 13, 2024
BRupireddy2
deleted the
add_pgactive_worker_error_reporting_facility_WIP
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables pgactive per-db and apply workers to report their last error into shared memory. Users can see the last error info via pgactive_get_workers_info SQL function.
One error for each per-db and apply worker is added for now. This can be extended to other errors by adding a specific pgactive error code and emitting error via the ereport_pgactive() in place of ereport()/elog().
This last error info improves observability of the pgactive setups.
===========================================================================================
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.