Added WebForms appsettings template and action #137
Conversation
- Added a new template and folder so that web.config can be converted outside of WebForms action - Added action to project.all.json corresponding to new action code in CTA
jonlouie
left a comment
jonlouie
left a comment
There was a problem hiding this comment.
Just double checking- in CTA, these actions will only execute when the project type is Web Forms?
recommendation/project.all.json
Outdated
| { | ||
| "Name": "WebFormsPorting", | ||
| "Type": "ProjectType", | ||
| "Value": "", | ||
| "Description": "Perform WebForms specific porting steps" | ||
| } |
There was a problem hiding this comment.
Is this valid if we're porting to .netstandard2.1?
.NET Standard apps are compatible with both .NET Framework and .NET Core runtimes, so my understanding here is that Blazor will not be available to apps targeting .NET Standard... but I could be wrong.
There was a problem hiding this comment.
Good catch here, after some looking it appears that .NET Standard supports Blazor WebAssembly but not Blazor Server (which we use) so I'll remove this one
@jonlouie Yes, the action checks that the project type is WebForms |
- Removed action from .net standard 2.1 in project.all.json
| }, | ||
| { | ||
| "Name": "WebFormsPorting", | ||
| "Type": "ProjectType", |
There was a problem hiding this comment.
Is ProjectType a new action type we're adding?
There was a problem hiding this comment.
Yes, I added a new action type called project type. I figured WCF and any other stuff that would otherwise be used with a project rewriter could be put under this action type
* These files are also used as temp tag configs in aws/cta#622
comsemer
dismissed stale reviews from marknfawaz, Eruanion, and jonlouie
via
0b35c0c
comsemer
requested review from
Beau-Gosse-dev,
Eruanion,
jonlouie and
marknfawaz
* Asp code behind types are now correctly ...Web.UI not ...UI.Web
…net-datastore into comsemer-webforms-as-action
* Added test
5 participants
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.