This repository was archived by the owner on Aug 26, 2020. It is now read-only.
Generic MPI - Create library to changehostname when mpi starts #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenyu
approved these changes
Dec 14, 2018
.flake8
Outdated
| [flake8] | ||
| application_import_names = sagemaker_containers, test | ||
| application_import_names = sagemaker_containers, test, libchangehostname | ||
| import-order-style = google |
laurenyu
approved these changes
Dec 14, 2018
| module = Py_InitModule3( | ||
| "libchangehostname", LibchangehostnameMethods, "Returns the value of $SM_CURRENT_HOST"); | ||
| } | ||
| #endif No newline at end of file |
Contributor
There was a problem hiding this comment.
nit: newline at the end of the file
nadiaya
reviewed
Dec 14, 2018
|
|
||
| int libchangehostname(char *name, size_t len) | ||
| { | ||
| const char *val = getenv("SM_CURRENT_HOST"); |
Contributor
There was a problem hiding this comment.
i don't really like that it depends on an environment variable that might now be initialized yet.
I understand that right now we call it at 'the right' time, but since it's not really guaranteed by anyone I am worried that it might cause issues in the future.
Also sagemaker-containers is not just a library used by us, we also advertise and help customers to use it in BYOC use case.
Anyway we can switch to use json file or guarantee that it's called only after this environment variable is initialized?
nadiaya
approved these changes
Dec 14, 2018
mvsusp
added a commit
that referenced
this pull request
Dec 19, 2018
* Generic MPI - Create library to changehostname when mpi starts (#153)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.