Skip to content

Conversation

@jakob-keller
Copy link
Contributor

Issue #, if available:

Description of changes: relax retrying dependency to support up-to-date releases, currently 1.3.4

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
  • I have updated any necessary documentation, including READMEs

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jakob-keller
Copy link
Contributor Author

@nskool 👀😀

@jakob-keller
Copy link
Contributor Author

Anyone?

@nikhil-sk
Copy link
Contributor

@chen3933 could you take a look as well?

nikhil-sk
nikhil-sk previously approved these changes Mar 14, 2023
@chen3933
Copy link

Check is not running. @nskool, did we add jakob-keller as collaborator?

@jakob-keller
Copy link
Contributor Author

Feel free to dismiss this PR and commit the change yourselves, if that helps 😅

@nikhil-sk nikhil-sk closed this Mar 21, 2023
@nikhil-sk nikhil-sk reopened this Mar 21, 2023
@nikhil-sk nikhil-sk closed this Mar 21, 2023
@nikhil-sk nikhil-sk reopened this Mar 21, 2023
@nikhil-sk nikhil-sk closed this Mar 22, 2023
@nikhil-sk nikhil-sk reopened this Mar 22, 2023
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-inference-toolkit-pr
  • Commit ID: 5d60c7c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nikhil-sk nikhil-sk merged commit 3207532 into aws:master Mar 22, 2023
@nikhil-sk
Copy link
Contributor

@chen3933 made changes to the webhook CI trigger to allow collaborators to 'reopen' a PR in order to trigger a build. That way, we do not have to add all contributors to the collaborators list, although that is an option. Going forward, collaborators can close and then reopen a PR to trigger a complete CI build.

@jakob-keller jakob-keller deleted the retrying branch March 22, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants