Skip to content

Conversation

@maaquib
Copy link
Contributor

@maaquib maaquib commented Mar 14, 2023

Issue #, if available: N/A

Description of changes: Adding support for py38, py39 and py310 and removing older versions (https://devguide.python.org/versions/)

Testing done:

$ tox test/unit
...
...
_____________________________________________________________________________________________________________________ summary _____________________________________________________________________________________________________________________
  black-format: commands succeeded
  flake8: commands succeeded
  pylint: commands succeeded
  twine: commands succeeded
  py38: commands succeeded
  py39: commands succeeded
  py310: commands succeeded
  congratulations :)

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
  • I have updated any necessary documentation, including READMEs

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@maaquib maaquib self-assigned this Mar 14, 2023
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-inference-toolkit-pr
  • Commit ID: 70a17d6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

pragma: no cover
pragma: py2 no cover
pragma: py3 no cover
if six.PY3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be perhaps be?

if six.PY2
elif six.PY2

If not, this is a bit confusing - could we add comment to explain what it means...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nskool Not really sure where this pragma comes from. I just kept the configuration the same as other py3 versions

@maaquib maaquib changed the title feature: Add support for py39 and py38 feature: Add support for py38, py39 and py310 Mar 16, 2023
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-inference-toolkit-pr
  • Commit ID: b5d43a2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@davidthomas426 davidthomas426 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maaquib maaquib merged commit 1db5525 into aws:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants