Skip to content

fix: skip HuggingFace tests in regions without p2 instances #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2021
Merged

fix: skip HuggingFace tests in regions without p2 instances #2244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/integ/test_huggingface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,15 @@
import pytest

from sagemaker.huggingface import HuggingFace
from tests import integ
from tests.integ import DATA_DIR, TRAINING_DEFAULT_TIMEOUT_MINUTES
from tests.integ.timeout import timeout


@pytest.mark.release
@pytest.mark.skipif(
integ.test_region() in integ.TRAINING_NO_P2_REGIONS, reason="no ml.p2 instances in this region"
)
def test_huggingface_training(
sagemaker_session,
gpu_instance_type,
Expand Down
6 changes: 6 additions & 0 deletions tests/integ/test_tfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,9 @@ def test_predict_with_accelerator(tfs_predictor_with_accelerator):


@pytest.mark.local_mode
@pytest.mark.skip(
reason="This test is broken due to a regression." "This test should be reenabled later."
)
def test_predict_with_entry_point(tfs_predictor_with_model_and_entry_point_same_tar):
input_data = {"instances": [1.0, 2.0, 5.0]}
expected_result = {"predictions": [4.0, 4.5, 6.0]}
Expand All @@ -170,6 +173,9 @@ def test_predict_with_entry_point(tfs_predictor_with_model_and_entry_point_same_


@pytest.mark.local_mode
@pytest.mark.skip(
reason="This test is broken due to a regression." "This test should be reenabled later."
)
def test_predict_with_model_and_entry_point_and_dependencies_separated(
tfs_predictor_with_model_and_entry_point_and_dependencies,
):
Expand Down