Skip to content

change: Remove unused dependency protobuf3-to-dict #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

change: Remove unused dependency protobuf3-to-dict #3869

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
766bcf5
Bump to protobuf4 and remove unused dependency protobuf3-to-dict
knikure May 18, 2023
232543b
Install other google packages to extend support for protobuf4
knikure May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,14 @@ def read_requirements(filename):
"boto3>=1.26.131,<2.0",
"cloudpickle==2.2.1",
"google-pasta",
"google-api-core==2.8.0",
"google-auth==2.6.6",
Copy link

@romibuzi romibuzi May 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @knikure, is there a reason to add these google dependencies? If so, I would be more in favor to define possible ranges values instead of strict version: google-auth>=2.6.6,<3.0

google-auth is now at version 2.18.1 for example: https://pypi.org/project/google-auth/#history. That means any project that uses sagemaker-sdk with another version of these google packages will have problem

"google-cloud-core==2.3.0",
"google-cloud-storage==2.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knikure lets discuss on the reason for pulling in so many direct dependencies, we have to check on the size concerns before merging this in.

"google-resumable-media==2.3.3",
"googleapis-common-protos==1.56.1",
"numpy>=1.9.0,<2.0",
"protobuf>=3.1,<4.0",
"protobuf3-to-dict>=0.1.5,<1.0",
"protobuf>=4.21.1,<5.0",
"smdebug_rulesconfig==1.0.1",
"importlib-metadata>=1.4.0,<5.0",
"packaging>=20.0",
Expand Down