Skip to content

fix: Fix unclear error messages for SageMaker Pipelines #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Fix unclear error messages for SageMaker Pipelines #3940

wants to merge 1 commit into from

Conversation

@navaj0
Copy link
Contributor

@navaj0 navaj0 commented Jun 19, 2023

Issue #, if available:

Description of changes: fix some unclear error messages for SageMaker pipelines

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • [N/A] I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • [N/A] I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • [N/A] I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • [N/A] I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • [N/A] I have checked that my tests are not configured for a specific region or account (if appropriate)
  • [N/A] I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@navaj0 navaj0 requested a review from a team as a code owner June 19, 2023 22:36
@navaj0 navaj0 requested review from jgoyani1 and removed request for a team June 19, 2023 22:36
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 558d942
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 558d942
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 558d942
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 558d942
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023 •
edited
Loading

Codecov Report

Merging #3940 (558d942) into master (7fc0857) will decrease coverage by 0.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3940      +/-   ##
==========================================
- Coverage   90.08%   89.38%   -0.71%     
==========================================
  Files        1156      271     -885     
  Lines      106908    26422   -80486     
==========================================
- Hits        96309    23616   -72693     
+ Misses      10599     2806    -7793
Impacted Files Coverage Δ
src/sagemaker/workflow/entities.py 97.43% <ø> (ø)
src/sagemaker/workflow/model_step.py 93.47% <ø> (ø)

... and 1425 files with indirect coverage changes

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 558d942
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure changed the title fix: fix some unclear error messages for SageMaker pipelines fix: Fix unclear error messages for SageMaker Pipelines Jun 20, 2023
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 558d942
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 558d942
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 558d942
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 558d942
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 558d942
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

akrishna1995
akrishna1995 reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@akrishna1995 akrishna1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run unit-tests

akrishna1995
akrishna1995 reviewed Jul 17, 2023
View reviewed changes
Copy link
Contributor

@akrishna1995 akrishna1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bot run notebook-tests

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 558d942
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 558d942
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@akrishna1995 akrishna1995 added the do-not-merge Use when PR needs to be marked as do not merge label Jul 17, 2023
akrishna1995
akrishna1995 suggested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@akrishna1995 akrishna1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the unit tests for this PR:

FAILED tests/unit/sagemaker/workflow/test_model_step.py::test_insert_wrong_step_args_into_model_step[inputs0]

4920 | FAILED tests/unit/sagemaker/workflow/test_model_step.py::test_insert_wrong_step_args_into_model_step[inputs1]
4921 | FAILED tests/unit/sagemaker/workflow/test_model_step.py::test_insert_wrong_step_args_into_model_step[inputs2]
4922 | FAILED tests/unit/sagemaker/workflow/test_model_step.py::test_insert_wrong_step_args_into_model_step[inputs3]

@akrishna1995
Copy link
Contributor

Closing the PR due to inactivity. Please reopen with requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgoyani1 jgoyani1 Awaiting requested review from jgoyani1 jgoyani1 is a code owner automatically assigned from aws/sagemaker-ml-frameworks

1 more reviewer

@akrishna1995 akrishna1995 akrishna1995 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@akrishna1995 akrishna1995

Labels

do-not-merge Use when PR needs to be marked as do not merge

Projects

PR Queue
Status: Closed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@navaj0 @sagemaker-bot @codecov-commenter @akrishna1995 @jgoyani1 @Zhankuil