Skip to content

fix: Configure RightSize recommendations to only select from realtime for now #4083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fix: Configure RightSize recommendations to only select from realtime for now #4083

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
518f0dc
fix: downgrade sklearn fw version to a regex format that ir supports
gwang111 Apr 14, 2023
a13179f
Revert "fix: downgrade sklearn fw version to a regex format that ir s…
gwang111 Apr 14, 2023
80ba644
only pick from realtime inference for now
gwang111 Aug 23, 2023
e513322
clean up
gwang111 Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/sagemaker/inference_recommender/inference_recommender_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,7 @@ def _update_params_for_right_size(
)
return None

instance_type = self.inference_recommendations[0]["EndpointConfiguration"]["InstanceType"]
initial_instance_count = self.inference_recommendations[0]["EndpointConfiguration"][
"InitialInstanceCount"
]
return (instance_type, initial_instance_count)
return self._filter_recommendations_for_realtime()

def _update_params_for_recommendation_id(
self,
Expand Down Expand Up @@ -610,3 +606,15 @@ def _search_recommendation(self, recommendation_list, inference_recommendation_i
),
None,
)

# TODO: until we have bandwidth to integrate right_size + deploy with serverless
def _filter_recommendations_for_realtime(self):
instance_type = None
initial_instance_count = None
for recommendations in self.inference_recommendations:
if not "serverlessConfig" in recommendations["EndpointConfiguration"]:
instance_type = recommendations["EndpointConfiguration"]["InstanceType"]
initial_instance_count = recommendations["EndpointConfiguration"][
"InitialInstanceCount"
]
return (instance_type, initial_instance_count)