Skip to content

feat: add telemetry for deployment config in model builder #4860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

feat: add telemetry for deployment config in model builder #4860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b227820
add deployment config type to response url
Sep 3, 2024
5901a6a
Trigger PR checks
Sep 4, 2024
507db15
Trigger PR checks
Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sagemaker/serve/builder/jumpstart_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ def __init__(self):
self.is_compiled = False
self.is_quantized = False
self.speculative_decoding_draft_model_source = None
self.deployment_config_name = None

@abstractmethod
def _prepare_for_mode(self, **kwargs):
Expand Down Expand Up @@ -511,6 +512,7 @@ def set_deployment_config(self, config_name: str, instance_type: str) -> None:
raise Exception("Cannot set deployment config to an uninitialized model.")

self.pysdk_model.set_deployment_config(config_name, instance_type)
self.deployment_config_name = config_name

self.instance_type = instance_type

Expand Down
4 changes: 4 additions & 0 deletions src/sagemaker/serve/utils/telemetry_logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,10 @@ def wrapper(self, *args, **kwargs):
model_provider_value = SD_DRAFT_MODEL_SOURCE_TO_CODE[str(model_provider_enum)]
extra += f"&x-sdDraftModelSource={model_provider_value}"

if getattr(self, "deployment_config_name", False):
config_name_code = self.deployment_config_name.lower()
extra += f"&x-configName={config_name_code}"

extra += f"&x-latency={round(elapsed, 2)}"

if not self.serve_settings.telemetry_opt_out:
Expand Down