fix: Add lambda_type parameter for Nova models and migrate to ModelPackage #5374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….get()
- Add lambda_type: rft parameter for Nova models in custom_scorer_evaluator
- Update pipeline templates to conditionally include lambda_type hyperparameter
- Migrate model_resolution.py from boto3 to sagemaker.core ModelPackage.get()
- Fix hub_content_arn construction when not provided by API
- Update and add unit tests for all changes
Testing done:
1. Ran Nova eval custom scorer.
2. Updated/ran unit tests
mufaddal-rohawala
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mufaddal-rohawala
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
rsareddy0329
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
rsareddy0329
approved these changes
Dec 5, 2025
jam-jee
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add lambda_type parameter for Nova models and migrate to ModelPackage…
Testing done:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.