Update EI section in regards to model loading within MXNet README #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 30, 2019 17:24
laurenyu
reviewed
Jan 31, 2019
Contributor
laurenyu
left a comment
laurenyu
left a comment
There was a problem hiding this comment.
lgtm. just a couple small comments.
Contributor
|
And also please change the PR title/commit message to be an imperative statement |
Contributor
|
now that #622 has been merged, these changes need to also happen in the sphinx docs |
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
=======================================
Coverage 92.73% 92.73%
=======================================
Files 71 71
Lines 5437 5437
=======================================
Hits 5042 5042
Misses 395 395Continue to review full report at Codecov.
|
ChoiByungWook
changed the title
laurenyu
reviewed
Jan 31, 2019
laurenyu
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
In reference to aws/sagemaker-mxnet-training-toolkit#65 (comment). Recommended to move documentation update from https://github.com/aws/sagemaker-mxnet-container to here.
Description of changes:
Add detail on loading model for EI in model loading section.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.