Skip to content

Fix flake8 errors #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Fix flake8 errors #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions tests/integ/test_mxnet_train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,16 +102,16 @@ def test_deploy_model_with_update_non_existing_endpoint(mxnet_training_job, sage
'please use an existing endpoint name'.format(endpoint_name)

with timeout_and_delete_endpoint_by_name(endpoint_name, sagemaker_session):
desc = sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=mxnet_training_job)
model_data = desc['ModelArtifacts']['S3ModelArtifacts']
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'mnist.py')
model = MXNetModel(model_data, 'SageMakerRole', entry_point=script_path,
py_version=PYTHON_VERSION, sagemaker_session=sagemaker_session)
model.deploy(1, 'ml.t2.medium', endpoint_name=endpoint_name)
sagemaker_session.describe_endpoint(EndpointName=endpoint_name)

with pytest.raises(ValueError, message=expected_error_message):
model.deploy(1, 'ml.m4.xlarge', update_endpoint=True, endpoint_name='non-existing-endpoint')
desc = sagemaker_session.sagemaker_client.describe_training_job(TrainingJobName=mxnet_training_job)
model_data = desc['ModelArtifacts']['S3ModelArtifacts']
script_path = os.path.join(DATA_DIR, 'mxnet_mnist', 'mnist.py')
model = MXNetModel(model_data, 'SageMakerRole', entry_point=script_path,
py_version=PYTHON_VERSION, sagemaker_session=sagemaker_session)
model.deploy(1, 'ml.t2.medium', endpoint_name=endpoint_name)
sagemaker_session.describe_endpoint(EndpointName=endpoint_name)

with pytest.raises(ValueError, message=expected_error_message):
model.deploy(1, 'ml.m4.xlarge', update_endpoint=True, endpoint_name='non-existing-endpoint')


@pytest.mark.continuous_testing
Expand Down
8 changes: 4 additions & 4 deletions tests/unit/test_tuner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ def test_stop_tuning_job(sagemaker_session, tuner):

def test_stop_tuning_job_no_tuning_job(tuner):
with pytest.raises(ValueError) as e:
tuner.stop_tuning_job()
tuner.stop_tuning_job()
assert 'No tuning job available' in str(e)


Expand Down Expand Up @@ -612,7 +612,7 @@ def test_transfer_learning_tuner(sagemaker_session):
def test_continuous_parameter():
cont_param = ContinuousParameter(0.1, 1e-2)
assert isinstance(cont_param, ParameterRange)
assert cont_param.__name__ is 'Continuous'
assert cont_param.__name__ == 'Continuous'


def test_continuous_parameter_ranges():
Expand All @@ -627,7 +627,7 @@ def test_continuous_parameter_ranges():
def test_integer_parameter():
int_param = IntegerParameter(1, 2)
assert isinstance(int_param, ParameterRange)
assert int_param.__name__ is 'Integer'
assert int_param.__name__ == 'Integer'


def test_integer_parameter_ranges():
Expand All @@ -642,7 +642,7 @@ def test_integer_parameter_ranges():
def test_categorical_parameter_list():
cat_param = CategoricalParameter(['a', 'z'])
assert isinstance(cat_param, ParameterRange)
assert cat_param.__name__ is 'Categorical'
assert cat_param.__name__ == 'Categorical'


def test_categorical_parameter_list_ranges():
Expand Down