Skip to content

Conversation

@yangaws
Copy link
Contributor

@yangaws yangaws commented Sep 20, 2018

Issue #, if available:

Description of changes:
Update gov cloud account number and add related unit tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

CHANGELOG
=========

1.1.5dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this still be dev?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep the release date is next week. We can submit final PR at that time.

@codecov-io
Copy link

codecov-io commented Sep 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@327dd1a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #71   +/-   ##
=========================================
  Coverage          ?   92.23%           
=========================================
  Files             ?       52           
  Lines             ?     3115           
  Branches          ?       82           
=========================================
  Hits              ?     2873           
  Misses            ?      242           
  Partials          ?        0
Impacted Files Coverage Δ
...gemaker/sparksdk/algorithms/ImageURIProvider.scala 96.87% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 327dd1a...bdd1974. Read the comment docs.

@ChoiByungWook ChoiByungWook merged commit fa61b11 into aws:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants