Fix deserialization of dicts for json predict requests #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvsusp
reviewed
Sep 18, 2018
Contributor
mvsusp
left a comment
mvsusp
left a comment
There was a problem hiding this comment.
Thanks for doing this. Besides docstrings, it seems that everything if fine.
| Returns: | ||
| dict<string, tensor_proto> | ||
Contributor
There was a problem hiding this comment.
Can we change the docstrings to reflect the behaviour change?
|
|
||
| if isinstance(data, tensor_pb2.TensorProto): | ||
| return {self.input_tensor_name: data} | ||
| def _value_to_tensor(self, value): |
Contributor
There was a problem hiding this comment.
Please add some docstring here too.
mvsusp
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#71
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.