Add support for string/parameter based Enabled for DeploymentPreference #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see black-check is failing. I think you may want to update your onboarding doc/makefile to download the correct versions of python, black, etc. I'll try to fix and re-submit. |
Codecov Report
@@ Coverage Diff @@
## develop #1361 +/- ##
===========================================
+ Coverage 94.42% 94.42% +<.01%
===========================================
Files 78 78
Lines 4554 4555 +1
Branches 912 912
===========================================
+ Hits 4300 4301 +1
Misses 119 119
Partials 135 135
Continue to review full report at Codecov.
|
keetonian
approved these changes
Jan 6, 2020
praneetap
approved these changes
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#350
Description of changes:
This change allows developers to reference string parameters to enable or disable deployment preferences. Previously, any non-empty string evaluated to true and any empty string evaluated to false.
Description of how you validated changes:
Created new unit tests and ran make test
Checklist:
make prpassesmake prwould not work, asmake black-checkwas failing, even before making my changes. I tried using both python2.7 and python3.6. Any guidance here would be appreciated.examples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.