Skip to content

Conversation

@keetonian
Copy link
Contributor

@keetonian keetonian commented Jan 21, 2020

Issue #, if available:
#1401

Description of changes:
X-Ray is now using the AWSXRayDaemonWriteAccess policy. This policy has the exact same permissions as AWSXrayWriteOnlyAccess, which is being deprecated.

Description of how you validated changes:

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

Codecov Report

Merging #1405 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1405   +/-   ##
========================================
  Coverage    94.42%   94.42%           
========================================
  Files           78       78           
  Lines         4660     4660           
  Branches       929      929           
========================================
  Hits          4400     4400           
  Misses         121      121           
  Partials       139      139
Impacted Files Coverage Δ
samtranslator/model/sam_resources.py 94.05% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be0b07...fc9ed47. Read the comment docs.

@praneetap praneetap self-assigned this Jan 22, 2020
@jlhood jlhood merged commit 2d5d7a0 into aws:develop Jan 27, 2020
keetonian added a commit to keetonian/serverless-application-model that referenced this pull request Feb 14, 2020
keetonian added a commit that referenced this pull request Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants