Skip to content

fix: use isinstance check instead of type #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2020
Merged

fix: use isinstance check instead of type #1411

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd5f016
fix: use isinstance check instead of type
jlhood Jan 23, 2020
7a7adb3
Merge branch 'develop' into develop
keetonian Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samtranslator/translator/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def _get_function_names(self, resource_dict, intrinsics_resolver):
# adds to the function_names dict with key as the api_name and value as the function_name
if item.get("Type") == "Api" and item.get("Properties") and item.get("Properties").get("RestApiId"):
rest_api = item.get("Properties").get("RestApiId")
if type(rest_api) == dict or isinstance(rest_api, dict):
if isinstance(rest_api, dict):
api_name = item.get("Properties").get("RestApiId").get("Ref")
else:
api_name = item.get("Properties").get("RestApiId")
Expand Down