Skip to content

Conversation

@keetonian
Copy link
Contributor

@keetonian keetonian commented Feb 13, 2020

Issue #, if available:
aws-cloudformation/cfn-lint#1325

Description of changes:
Do a correct type check, which will fix a recent SAM bug in cfn-lint

Description of how you validated changes:
make pr

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #1449 into release/v1.21.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v1.21.0    #1449   +/-   ##
================================================
  Coverage            94.38%   94.38%           
================================================
  Files                   78       78           
  Lines                 4683     4683           
  Branches               938      938           
================================================
  Hits                  4420     4420           
  Misses                 121      121           
  Partials               142      142
Impacted Files Coverage Δ
samtranslator/translator/translator.py 98.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e55672...95bdd62. Read the comment docs.

@keetonian keetonian merged commit 4432ddd into aws:release/v1.21.0 Feb 13, 2020
@keetonian keetonian deleted the release-1.21.0-patch branch February 13, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants