Skip to content

Conversation

@keetonian
Copy link
Contributor

@keetonian keetonian commented Mar 5, 2020

Issue #, if available:
#1478

Description of changes:
Propagates tags to generated resources.

Description of how you validated changes:
Deployed templates with sample changes, unit testing.

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Add/update example to examples/2016-10-31

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alexw91
Copy link

alexw91 commented Mar 5, 2020

Codecov Report

Merging #1492 into develop will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1492   +/-   ##
========================================
  Coverage    94.13%   94.13%           
========================================
  Files           78       78           
  Lines         4926     4928    +2     
  Branches       991      991           
========================================
+ Hits          4637     4639    +2     
  Misses         134      134           
  Partials       155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe4fdd...dd64074. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #1492 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1492      +/-   ##
===========================================
+ Coverage    94.13%   94.13%   +<.01%     
===========================================
  Files           78       78              
  Lines         4926     4928       +2     
  Branches       991      991              
===========================================
+ Hits          4637     4639       +2     
  Misses         134      134              
  Partials       155      155
Impacted Files Coverage Δ
samtranslator/model/apigatewayv2.py 94.73% <ø> (ø) ⬆️
samtranslator/model/api/http_api_generator.py 92.33% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fe4fdd...dd64074. Read the comment docs.

@keetonian keetonian merged commit e9c0aa6 into aws:develop Mar 5, 2020
@keetonian keetonian deleted the http-tags-resources branch March 11, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants