Skip to content

fix(AppConfig): Updated AppConfig boto3 Client Timeout #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2021
Merged

fix(AppConfig): Updated AppConfig boto3 Client Timeout #1870

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09b2a00
Updated AppConfig boto3 Client Timeout
CoshUS Dec 17, 2020
88f2759
Reformatted with Black
CoshUS Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion samtranslator/feature_toggle/feature_toggle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
import boto3
import logging

from botocore.config import Config

my_path = os.path.dirname(os.path.abspath(__file__))
sys.path.insert(0, my_path + "/..")

Expand Down Expand Up @@ -105,8 +107,11 @@ class FeatureToggleAppConfigConfigProvider(FeatureToggleConfigProvider):

def __init__(self, application_id, environment_id, configuration_profile_id):
FeatureToggleConfigProvider.__init__(self)
self.app_config_client = boto3.client("appconfig")
try:
# Lambda function has 120 seconds limit
# (5 + 25) * 2, 60 seconds maximum timeout duration
client_config = Config(connect_timeout=5, read_timeout=25, retries={"total_max_attempts": 2})
self.app_config_client = boto3.client("appconfig", config=client_config)
response = self.app_config_client.get_configuration(
Application=application_id,
Environment=environment_id,
Expand Down