-
Couldn't load subscription status.
- Fork 2.4k
feat: Handle Fn::If intrinsic for Alarms #1923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…f, transforms the alarms inside into CFN format and passes it to CFN
samtranslator/model/preferences/deployment_preference_collection.py
Outdated
Show resolved
Hide resolved
samtranslator/model/preferences/deployment_preference_collection.py
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #1923 +/- ##
===========================================
+ Coverage 93.85% 93.94% +0.08%
===========================================
Files 89 89
Lines 5890 5926 +36
Branches 1206 1212 +6
===========================================
+ Hits 5528 5567 +39
+ Misses 166 164 -2
+ Partials 196 195 -1
Continue to review full report at Codecov.
|
Issue #, if available:
#1624
Description of changes:
Handles
Fn::IfinDeploymentPreference/Alarmswhere we would only allow a list before.Description of how you validated changes:
Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.