Fix missing xray policy for State Machine resource #1941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrandis
reviewed
Feb 25, 2021
mgrandis
approved these changes
Feb 25, 2021
wchengru
approved these changes
Feb 25, 2021
mgrandis
pushed a commit
to mgrandis/serverless-application-model
that referenced
this pull request
Mar 2, 2021
* Fix missing xray policy for State Machine resource * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1728
Description of changes:
If
tracingis enabled andPoliciesis used in the State Machine resource, the created IAM role for the State Machine resource will include a correct X Ray managed policy (depending on partition).Description of how you validated changes:
Add tests to cover case when
tracingis enabled andPoliciesis used in the State Machine resource in a template.Checklist:
make prpassesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.