fix(policy-templates): Correct AMIDescribePolicy #1945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The action underlying this policy does not take a resource. Resolves #1944
Codecov Report
@@ Coverage Diff @@
## develop #1945 +/- ##
========================================
Coverage 93.88% 93.88%
========================================
Files 90 90
Lines 5954 5954
Branches 1213 1213
========================================
Hits 5590 5590
Misses 168 168
Partials 196 196 Continue to review full report at Codecov.
|
mgrandis
approved these changes
Mar 1, 2021
mgrandis
pushed a commit
to mgrandis/serverless-application-model
that referenced
this pull request
Mar 2, 2021
The action underlying this policy does not take a resource. Resolves aws#1944
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action underlying this policy does not take a particular resource.
Issue #, if available:
Resolves #1944
Description of changes:
Removes templated ARN from
AMIDescribePolicy, replacing it with a static*.Description of how you validated changes:
Aside from the translator tests, created a Lambda Function using these permissions and successfully performed the action.
Checklist:
make prpassesUpdate documentationThe documentation appears not to be in the repo – wherever that is will have to be updated. Maybe it's generated?Examples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.