Skip to content

Conversation

@mgrandis
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021

Codecov Report

Merging #2068 (9bfade0) into develop (e7a1496) will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2068      +/-   ##
===========================================
+ Coverage    93.58%   93.87%   +0.28%     
===========================================
  Files           90       91       +1     
  Lines         6124     6168      +44     
  Branches      1260     1262       +2     
===========================================
+ Hits          5731     5790      +59     
+ Misses         183      174       -9     
+ Partials       210      204       -6     
Impacted Files Coverage Δ
samtranslator/model/apigateway.py 97.15% <ø> (ø)
samtranslator/model/sam_resources.py 91.23% <ø> (ø)
samtranslator/__init__.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/dialup.py 100.00% <100.00%> (ø)
samtranslator/feature_toggle/feature_toggle.py 100.00% <100.00%> (+12.16%) ⬆️
samtranslator/model/api/api_generator.py 94.39% <100.00%> (+0.03%) ⬆️
samtranslator/translator/translator.py 97.18% <100.00%> (ø)
samtranslator/swagger/swagger.py 93.89% <0.00%> (+0.52%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39d0a0...9bfade0. Read the comment docs.

@mgrandis mgrandis merged commit 5a581fd into aws:develop Jun 23, 2021
mgrandis added a commit to mgrandis/serverless-application-model that referenced this pull request Jun 23, 2021
mgrandis added a commit that referenced this pull request Jun 23, 2021
* Revert "fix: Crash when using an invalid method in open api (#2001)" (#2021)

This reverts commit d57b132.

* fix: Increase PageSize of ListPolicies Paginator (#2033)

SAM runs within a Lambda function and loads IAM Managed Policies once per
Lambda. Previous to this, SAM would call IAM 9 times which could cause
throttling by IAM. With this change, we update the MaxItems from the
default of 100 to the max (1000). In local testing, this has shown
a 0.6 second reduction in the latency in calling IAM.

Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>

* Revert "Issue 1508 remove check requiring identity ... (#1577)" (#2038)

This reverts commit 0eb3630.

This change caused regression, reverting until the bug is fixed.

bug: `ReauthorizeEvery` can be a `dict` when intrinsic functions are used.

* chore: bump version to 1.37.0 (#2068)

Co-authored-by: Jacob Fuss <32497805+jfuss@users.noreply.github.com>
Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>
Co-authored-by: _sam <3804518+aahung@users.noreply.github.com>
mgrandis added a commit that referenced this pull request Jul 6, 2021
* Release/v1.37.0 (#2069)
* chore: bump version to 1.37.0 (#2068)

* fix: Increase PageSize of ListPolicies Paginator (#2033)
Co-authored-by: Jacob Fuss <32497805+jfuss@users.noreply.github.com>
Co-authored-by: Jacob Fuss <jfuss@users.noreply.github.com>

* feat: Support VIRTUAL_HOST as Type for SourceAccessConfiguration for MQ events (#76) (#2078)
Co-authored-by: Renato Valenzuela <37676028+valerena@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants