Skip to content

Conversation

jordanvance
Copy link
Contributor

@jordanvance jordanvance commented Sep 22, 2022

  • Bump jsonschema version
  • Make jsonschema requirement more flexible

Issue #, if available:
#2426

Description of changes:

Description of how you validated changes:

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Sep 22, 2022
@jordanvance
Copy link
Contributor Author

follow on to #2441

@jordanvance
Copy link
Contributor Author

@hawflau i think this will address the changes that @jfuss had wanted on #2441

@jordanvance jordanvance requested a review from a team as a code owner November 17, 2022 12:38
Copy link
Contributor

@aahung aahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Add comment to base.txt requirements around jsonschema 3.x
jordanvance and others added 2 commits November 17, 2022 15:04
Add comment linking to issue #2426

Co-authored-by: Chris Rehn <1280602+hoffa@users.noreply.github.com>
@hoffa hoffa changed the title flexible jsonschema version chore: flexible jsonschema version Nov 17, 2022
Co-authored-by: _sam <3804518+aahung@users.noreply.github.com>
@aahung aahung enabled auto-merge (squash) November 17, 2022 20:59
@aahung aahung merged commit 66636f1 into aws:develop Nov 17, 2022
@jordanvance
Copy link
Contributor Author

Thanks @hoffa @tomviner @aahung!

@aahung aahung mentioned this pull request Nov 17, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer/need-response stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants