Skip to content

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Oct 4, 2022

Issue #, if available:
aws-cloudformation/cfn-lint#2395

Description of changes:

  • More pythonic way of determining a type of a value

Description of how you validated changes:

Checklist:

  • Add/update unit tests using:
  • Add/update integration tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Oct 4, 2022
@GavinZZ
Copy link
Contributor

GavinZZ commented Oct 28, 2022

Thanks @kddejong for the input. Wondering is this type check change addressing any bug in the repo?

@kddejong
Copy link
Contributor Author

It's for an issue with cfn-lint. We override the list type so it's still complies with isinstance but not with stricter type check that is there now

@kddejong kddejong force-pushed the fix/event/pull/typechecking branch from 59b933e to a77f41b Compare November 1, 2022 17:02
@kddejong kddejong force-pushed the fix/event/pull/typechecking branch from a77f41b to 42570d8 Compare November 1, 2022 17:04
@kddejong
Copy link
Contributor Author

kddejong commented Nov 1, 2022

rebased to develop

@hoffa hoffa merged commit 9423359 into aws:develop Nov 2, 2022
@kddejong kddejong deleted the fix/event/pull/typechecking branch November 22, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintainer/need-response stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants