-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add ability to set Name of EventBridge Rule #2525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set Name of EventBridge Rule #2525
Conversation
45ca2e5
to
834fb27
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2525 +/- ##
===========================================
+ Coverage 93.58% 94.43% +0.84%
===========================================
Files 90 99 +9
Lines 6124 7615 +1491
Branches 1260 1597 +337
===========================================
+ Hits 5731 7191 +1460
- Misses 183 205 +22
- Partials 210 219 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
834fb27
to
9b1bbe4
Compare
9b1bbe4
to
c412354
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Same as the previous PR,
- Can we have some transform tests?
Can we support the SFN'sSchedule
as well to make them consistent?
@aahung transform tests added |
@aahung will you be able to merge that if I go ahead and resolve the conflicts? |
Resolved conflicts, will merge once CI checks pass |
Issue #, if available:
#2508
Description of changes:
Added
RuleName
Property toEventBridgeRule
resource which translates toName
property inAWS::Events::Rule
Description of how you validated changes:
Used bin/sam-translate.py to generate a CFN template from SAM template which I then successfully deployed in my AWS account with desired changes taking effect.
Checklist:
make pr
passesExamples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam init
through https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.