Skip to content

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Oct 12, 2022

Issue #, if available

#2534

Description of changes

Description of how you validated changes

Checklist

  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #2536 (85085ff) into develop (e7a1496) will increase coverage by 0.65%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2536      +/-   ##
===========================================
+ Coverage    93.58%   94.23%   +0.65%     
===========================================
  Files           90      100      +10     
  Lines         6124     7638    +1514     
  Branches      1260     1606     +346     
===========================================
+ Hits          5731     7198    +1467     
- Misses         183      219      +36     
- Partials       210      221      +11     
Impacted Files Coverage Δ
samtranslator/region_configuration.py 77.77% <0.00%> (-22.23%) ⬇️
samtranslator/model/codedeploy.py 90.90% <0.00%> (-9.10%) ⬇️
samtranslator/validator/validator.py 91.80% <0.00%> (-3.85%) ⬇️
samtranslator/model/exceptions.py 97.67% <0.00%> (-2.33%) ⬇️
samtranslator/model/__init__.py 95.65% <0.00%> (-2.00%) ⬇️
samtranslator/open_api/open_api.py 90.16% <0.00%> (-1.81%) ⬇️
samtranslator/model/s3_utils/uri_parser.py 68.42% <0.00%> (-0.81%) ⬇️
samtranslator/yaml_helper.py 89.47% <0.00%> (-0.53%) ⬇️
samtranslator/translator/logical_id_generator.py 90.62% <0.00%> (-0.29%) ⬇️
samtranslator/model/apigateway.py 96.98% <0.00%> (-0.18%) ⬇️
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hoffa hoffa changed the title Support SOURCE_EVENT_SOURCE_MAPPING_DLQ dependency feat: automatically add DependsOn Oct 12, 2022
@hoffa hoffa changed the title feat: automatically add DependsOn feat: automatically add DependsOn for Lambda to SQS DLQ on ESM Oct 12, 2022
@hoffa
Copy link
Contributor Author

hoffa commented Oct 19, 2022

Decided to go with #2537

@hoffa hoffa closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants