-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Bug fix: Fix DisableExecuteApiEndpoint bug fix #2560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Out of curiosity, how did you generate the transform test input and output files? Did you try using the script |
Didn't use the script unfortunately |
That's alright. FYI, you can use the script for easier file generation. It will generate the 3 files each for one partition, add to the correct directories and add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the changes Chris mentioned, rest LGTM
Issue #, if available
2396
Description of changes
The
DisableExecuteApiEndpoint
property in Serverless API didn't work if theOpenApiVersion
was 3 because, when transformed, it didn't add thex-amazon-apigateway-endpoint-configuration
extension to the Servers object as stated in this guide. Now it adds the extension to the Servers object.Description of how you validated changes
Checklist
Examples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam init
through https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.