Skip to content

Conversation

aaythapa
Copy link
Contributor

Issue #, if available

2396

Description of changes

The DisableExecuteApiEndpoint property in Serverless API didn't work if the OpenApiVersion was 3 because, when transformed, it didn't add the x-amazon-apigateway-endpoint-configuration extension to the Servers object as stated in this guide. Now it adds the extension to the Servers object.

Description of how you validated changes

Checklist

  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Oct 21, 2022
@GavinZZ
Copy link
Contributor

GavinZZ commented Oct 21, 2022

Out of curiosity, how did you generate the transform test input and output files? Did you try using the script add_transform_test.py?

@aaythapa
Copy link
Contributor Author

aaythapa commented Oct 21, 2022

Out of curiosity, how did you generate the transform test input and output files? Did you try using the script add_transform_test.py?

Didn't use the script unfortunately

@GavinZZ
Copy link
Contributor

GavinZZ commented Oct 21, 2022

Out of curiosity, how did you generate the transform test input and output files? Did you try using the script add_transform_test.py?

Didn't use the script unfortunately

That's alright. FYI, you can use the script for easier file generation. It will generate the 3 files each for one partition, add to the correct directories and add REGIONAL endpoint configuration for you.

Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the changes Chris mentioned, rest LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants