-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Create SAM StateMachine without providing a role or policy #2606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SAM StateMachine without providing a role or policy #2606
Conversation
work without policy
better policy
when giving both a role and policy
integration/resources/expected/combination/connector_sfn_to_function_without_policy.json
Outdated
Show resolved
Hide resolved
…github.com/aws/serverless-application-model into WIP-Create-SAM-Statemachine-without-Policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally look good to me! Thanks! Can we add a transform test so that we can take a look on what is generated?
integration/resources/templates/combination/connector_sfn_to_function_without_policy.yaml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing the comments!
Issue #, if available
Description of changes
Allows a SAM StateMachine to be created without a policy or role by generating a role when no role or policy is given.
Description of how you validated changes
Added a test that uses Connectors without giving the SAM StateMachine a policy and changed the no policy given to test to see if a Role exists.
Checklist
Examples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam init
through https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.