Skip to content

Conversation

ConnorRobertson
Copy link

Issue #, if available

Description of changes

Allows a SAM StateMachine to be created without a policy or role by generating a role when no role or policy is given.

Description of how you validated changes

Added a test that uses Connectors without giving the SAM StateMachine a policy and changed the no policy given to test to see if a Role exists.

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ConnorRobertson ConnorRobertson requested a review from a team as a code owner November 17, 2022 20:33
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 17, 2022
Copy link
Contributor

@aahung aahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally look good to me! Thanks! Can we add a transform test so that we can take a look on what is generated?

Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing the comments!

@ConnorRobertson ConnorRobertson merged commit 06c8cf6 into develop Nov 22, 2022
@ConnorRobertson ConnorRobertson deleted the WIP-Create-SAM-Statemachine-without-Policy branch November 22, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants