Skip to content

chore: Enforce formatting for yaml/json and add Test Metadata #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2022
Merged

chore: Enforce formatting for yaml/json and add Test Metadata #2617

merged 1 commit into from
Nov 18, 2022

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Nov 18, 2022 •
edited
Loading

Issue #, if available

Description of changes

Modified all yamljson formats. Add test metadata to integ test yaml files.

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner November 18, 2022 19:36
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 18, 2022
@GavinZZ GavinZZ mentioned this pull request Nov 18, 2022
Closed
10 tasks
@GavinZZ GavinZZ added pr/internal and removed pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 18, 2022
@GavinZZ GavinZZ changed the title Enforce formatting for yaml/json and add Test Metadata chore: Enforce formatting for yaml/json and add Test Metadata Nov 18, 2022
acristin
acristin approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@acristin acristin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks beautiful now. As much as JSON can.

@GavinZZ GavinZZ merged commit f430598 into develop Nov 18, 2022
@GavinZZ GavinZZ deleted the format_test_files branch November 23, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@acristin acristin acristin approved these changes

@hoffa hoffa hoffa approved these changes

@aahung aahung aahung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GavinZZ @acristin @hoffa @aahung