Skip to content

Add Schema Type to AWS::Serverless::Lambda #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 21, 2022
Merged

Add Schema Type to AWS::Serverless::Lambda #2623

merged 5 commits into from
Nov 21, 2022

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Nov 19, 2022 •
edited by hoffa
Loading

Issue #, if available

#1133

Description of changes

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner November 19, 2022 00:06
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Nov 19, 2022
aahung
aahung reviewed Nov 19, 2022
View reviewed changes
hoffa
hoffa reviewed Nov 19, 2022
View reviewed changes
hoffa
hoffa reviewed Nov 19, 2022
View reviewed changes
hoffa
hoffa reviewed Nov 19, 2022
View reviewed changes
@GavinZZ GavinZZ force-pushed the schema_type_function branch 2 times, most recently from c0696e4 to 5f95f4e Compare November 19, 2022 01:09
hoffa
hoffa reviewed Nov 21, 2022
View reviewed changes
hoffa
hoffa reviewed Nov 21, 2022
View reviewed changes
@GavinZZ GavinZZ force-pushed the schema_type_function branch from 0b20bdb to 5a714fc Compare November 21, 2022 18:34
hoffa
hoffa reviewed Nov 21, 2022
View reviewed changes
@GavinZZ GavinZZ force-pushed the schema_type_function branch from 4922630 to 4594957 Compare November 21, 2022 20:57
@GavinZZ GavinZZ merged commit c91973a into develop Nov 21, 2022
@hoffa hoffa deleted the schema_type_function branch November 21, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hoffa hoffa hoffa approved these changes

@aahung aahung aahung approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GavinZZ @hoffa @aahung