Skip to content

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Nov 22, 2022

Issue #, if available

#1133

Description of changes

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner November 22, 2022 21:28
@GavinZZ GavinZZ force-pushed the validate_schema_as_unit_test branch from 0fa947b to 219f311 Compare November 22, 2022 21:34
acristin
acristin previously approved these changes Nov 22, 2022
Copy link
Contributor

@acristin acristin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but it would be useful to document the reasoning behind moving from a lint task to a unit test.

@acristin acristin dismissed their stale review November 22, 2022 21:43

Should have just been a comment

@GavinZZ GavinZZ force-pushed the validate_schema_as_unit_test branch from ebd5de7 to eda9bcc Compare November 22, 2022 22:23
@GavinZZ GavinZZ force-pushed the validate_schema_as_unit_test branch from 04c3d9d to cca8fd8 Compare November 22, 2022 22:29
@GavinZZ GavinZZ requested a review from hoffa November 22, 2022 22:52
@hoffa hoffa merged commit 0780e15 into develop Nov 22, 2022
@hoffa hoffa deleted the validate_schema_as_unit_test branch November 22, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants