-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Validate schema as unit test #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssenchenko
approved these changes
Nov 22, 2022
0fa947b
to
219f311
Compare
hoffa
reviewed
Nov 22, 2022
hoffa
reviewed
Nov 22, 2022
acristin
previously approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine, but it would be useful to document the reasoning behind moving from a lint task to a unit test.
hoffa
reviewed
Nov 22, 2022
xazhao
reviewed
Nov 22, 2022
ebd5de7
to
eda9bcc
Compare
hoffa
reviewed
Nov 22, 2022
tests/translator/output/error_schema_validation_wrong_type.json
Outdated
Show resolved
Hide resolved
04c3d9d
to
cca8fd8
Compare
hoffa
reviewed
Nov 22, 2022
hoffa
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
#1133
Description of changes
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam init
through https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.