Skip to content

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Nov 23, 2022

Issue #, if available

Description of changes

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@aahung aahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good! Just some minor error handling issues. Can we make sure those errors are correct using some transform tests?

@xazhao xazhao marked this pull request as ready for review November 24, 2022 18:17
@xazhao xazhao requested a review from a team as a code owner November 24, 2022 18:17
@xazhao
Copy link
Contributor Author

xazhao commented Nov 24, 2022

@aahung Actually those errors can not be approached by transform test. They will be errors before.

Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just some minor comments.

Copy link
Contributor

@aahung aahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@xazhao xazhao merged commit c9aac7a into aws:develop Nov 24, 2022
xazhao added a commit that referenced this pull request Dec 2, 2022
@xazhao xazhao mentioned this pull request Jan 27, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants