Skip to content

Conversation

xazhao
Copy link
Contributor

@xazhao xazhao commented Nov 24, 2022

Issue #, if available

The partition generated by the script is always aws
Now adding a new option to set partition to aws-cn or aws-us-gov based on the output path

Description of changes

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xazhao xazhao requested a review from a team as a code owner November 24, 2022 22:54
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think it would be nice to have this by default.

@xazhao
Copy link
Contributor Author

xazhao commented Nov 24, 2022

@GavinZZ There are some tests case which partition is hardcoded. In this case I don't want to have the script to update those arns.

Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 🙏

@hoffa
Copy link
Contributor

hoffa commented Nov 24, 2022

@GavinZZ There are some tests case which partition is hardcoded. In this case I don't want to have the script to update those arns.

I agree with @GavinZZ, why not have this by default? This script is only used for new tests, so I don't see why the existing tests matter.

@hoffa hoffa changed the title Update transform test script to update ManagedPolicyArn with partion feat: update transform test script to update ManagedPolicyArn with partion Nov 25, 2022
Co-authored-by: Chris Rehn <1280602+hoffa@users.noreply.github.com>
@xazhao xazhao enabled auto-merge (squash) November 25, 2022 22:06
@xazhao xazhao merged commit 0391c91 into aws:develop Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants