-
Notifications
You must be signed in to change notification settings - Fork 2.4k
feat: update transform test script to update ManagedPolicyArn with partion #2660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually think it would be nice to have this by default.
@GavinZZ There are some tests case which partition is hardcoded. In this case I don't want to have the script to update those arns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this 🙏
Co-authored-by: Chris Rehn <1280602+hoffa@users.noreply.github.com>
Issue #, if available
The partition generated by the script is always
aws
Now adding a new option to set partition to
aws-cn
oraws-us-gov
based on the output pathDescription of changes
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam init
through https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.