Skip to content

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Nov 25, 2022

Issue #, if available

Description of changes

We're moving feature discussions to Discussions, so Issues stays about issues.

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa requested a review from a team as a code owner November 25, 2022 21:11
@hoffa hoffa enabled auto-merge (squash) November 25, 2022 21:23
@hoffa hoffa merged commit 4beb746 into develop Nov 25, 2022
@hoffa hoffa deleted the hoffa-patch-2 branch November 25, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants