Convert Relative Paths to Full Paths In Schema #2671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add schema change Use HTML extension for docs Format file Format file
hoffa
approved these changes
Nov 25, 2022
hoffa
reviewed
Nov 25, 2022
GavinZZ
force-pushed
the
convert_to_full_path
branch
from
3dddf69 to
9da3668
Compare
xazhao
approved these changes
Nov 25, 2022
aahung
approved these changes
Nov 25, 2022
|
|
||
|
|
||
| def convert_to_full_path(description: str) -> str: | ||
| pattern = re.compile("\(([#\.a-zA-Z0-9_-]+)\)") |
There was a problem hiding this comment.
nit: we can move it to constant to avoid repeat compile
There was a problem hiding this comment.
can we give it a name to explain what we are trying to match?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add schema change
Use HTML extension for docs
Format file
Format file
Issue #, if available
#2662
Description of changes
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments, if you want to add an example. Examples will be
added to
sam initthrough https://github.com/awslabs/aws-sam-cli-app-templates/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.