chore: Cache get_partition_name to reduce transform latency #2774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinZZ
approved these changes
Jan 10, 2023
aaythapa
approved these changes
Jan 10, 2023
acristin
approved these changes
Jan 10, 2023
aahung
force-pushed
the
cache-get_partition_name
branch
from
1f7f38e to
05958e3
Compare
xazhao
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available
Tested on a template with 411 Api event sources. By looking at the profile result,
get_partition_name()is called 824 times, making up 10.76s (out of 47s, ~23%).After this change, it only called twice and only took 0.01s.
this brought down the time from 47s to 40s (the duration fluctuates so it doesn't have exact 10.76s difference).
Description of changes
Description of how you validated changes
Checklist
Examples?
Please reach out in the comments if you want to add an example. Examples will be
added to
sam initthrough aws/aws-sam-cli-app-templates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.